Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StandardError is now Exception #11997

Merged
merged 1 commit into from Oct 22, 2015

Conversation

ericvaandering
Copy link
Contributor

Exception, not StandardError is now the base class for all exceptions.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ericvaandering (Eric Vaandering) for CMSSW_8_0_X.

StandardError is now Exception

It involves the following packages:

CalibMuon/DTCalibration
Geometry/TrackerCommonData
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
PhysicsTools/PythonAnalysis
RecoHI/HiEgammaAlgos

@civanch, @diguida, @cvuosalo, @ianna, @mdhildreth, @monttj, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @slava77, @vadler, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @rappoccio, @venturia, @mmarionncern, @imarches, @makortel, @acaudron, @dgulhan, @jdolen, @ferencek, @mandrenguyen, @yetkinyilmaz, @VinInn, @nhanvtran, @schoef, @richard-cms, @jazzitup, @ahinzmann, @yenjie, @kurtejung, @gpetruc, @istaslis, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9073/console

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

+1

for #11997 fa69e3f

  • changes are as described (raise StandardError -> raise Exception)
  • jenkins tests pass; comparisons show no differences

@ianna
Copy link
Contributor

ianna commented Oct 21, 2015

+1

davidlange6 added a commit that referenced this pull request Oct 22, 2015
@davidlange6 davidlange6 merged commit 9487b63 into cms-sw:CMSSW_8_0_X Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants