Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to select vtx or beamspot covariance #12097

Merged
merged 1 commit into from Nov 3, 2015
Merged

allow user to select vtx or beamspot covariance #12097

merged 1 commit into from Nov 3, 2015

Conversation

fojensen
Copy link
Contributor

fixed a bug where the switch to allow the user to use the vertex instead of the beamspot did not correspondingly use the vertex as a reference to calculate the 3D & 2D decay significance

@slava77
Copy link
Contributor

slava77 commented Oct 26, 2015

@cmsbuild please test
@fojensen Frank, I suppose PRs for 75X and 76X are coming soon

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Oct 26, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9201/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fojensen (Frank Jensen) for CMSSW_7_4_X.

allow user to select vtx or beamspot covariance

It involves the following packages:

RecoVertex/V0Producer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fojensen
Copy link
Contributor Author

@slava77
once this goes through smoothly I was going submit the other two

On Mon, Oct 26, 2015 at 8:43 AM, Slava Krutelyov
notifications@github.com wrote:

@cmsbuild please test
@fojensen Frank, I suppose PRs for 75X and 76X are coming soon


Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 28, 2015

+1

for #12097 f054e42

  • select correct covariance for V0 reco with "useVertex" (non-default option)
  • jenkins tests pass and comparisons with baseline show no differences

@davidlange6 this will be needed for reference pp for HI

@fojensen please prepare 75X/76X/80X PRs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@fojensen
Copy link
Contributor Author

@slava77

I do not see my original 76x PR in the IB list:
#11699
https://cmssdt.cern.ch/SDT/html/showIB.html
I would like to use the IB to apply the fix
(as you can tell I found the 80X and the 75X)
thank you

On Tue, Oct 27, 2015 at 8:08 PM, Slava Krutelyov notifications@github.com
wrote:

+1

for #12097 #12097 f054e42
f054e42

  • select correct covariance for V0 reco with "useVertex" (non-default
    option)
  • jenkins tests pass and comparisons with baseline show no differences

@davidlange6 https://github.com/davidlange6 this will be needed for
reference pp for HI

@fojensen https://github.com/fojensen please prepare 75X/76X/80X PRs


Reply to this email directly or view it on GitHub
#12097 (comment).

@slava77
Copy link
Contributor

slava77 commented Oct 28, 2015

Frank, the #11699 was merged on Oct 9 (as you can see from the PR itself).
The showIB page displays only recent merges (the past 10 days or so).
You can use 760pre7 for the tests
https://github.com/cms-sw/cmssw/releases/CMSSW_7_6_0_pre7

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 3, 2015
allow user to select vtx or beamspot covariance
@cmsbuild cmsbuild merged commit 017f97d into cms-sw:CMSSW_7_4_X Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants