Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup statics. #1212

Merged
merged 1 commit into from Nov 25, 2013
Merged

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Oct 28, 2013

Substitute run-time table generation with equivalent constexpr.

Substitute run-time table generation with equivalent constexpr.
@ktf
Copy link
Contributor Author

ktf commented Oct 28, 2013

@cerminar @namapane

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

Cleanup statics.

It involves the following packages:

CondFormats/DTObjects

@smuzaffar, @apfeiffer1, @nclopezo, @demattia, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@demattia
Copy link
Contributor

And this also, same comment as 1210 and 1211. It would be good if it was possible to test them all together as the changes are not in the substance.

@nclopezo
Copy link
Contributor

+1
the errors in the unit tests are the ones that were already in the IB:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1058/summary.html

@apfeiffer1
Copy link
Contributor

+1

1 similar comment
@rcastello
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 25, 2013
Multithreading fixes -- Cleanup statics in DTSequentialCellNumber.
@ktf ktf merged commit 0ac52b2 into cms-sw:CMSSW_7_0_X Nov 25, 2013
@ktf ktf deleted the fix-statics-DTSequentialCellNumber branch November 25, 2013 08:26
ddiaz006 pushed a commit to ddiaz006/cmssw that referenced this pull request Feb 23, 2024
Update jet collection used by HPS taus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants