Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made SimpleMemoryCheck thread-safe #1213

Merged
merged 1 commit into from Oct 29, 2013

Conversation

Dr15Jones
Copy link
Contributor

Switched SimpleMemoryCheck to use the new Service APIs. In addition, switched to using std::atomics for thread safety. The module was changes so that if a callback is made while another callback is updating the memory measurement, the second callback just returns immediately.

Switched SimpleMemoryCheck to use the new Service APIs. In addition, switched to using std::atomics for thread safety. The module was changes so that if a callback is made while another callback is updating the memory measurement, the second callback just returns immediately.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Made SimpleMemoryCheck thread-safe

It involves the following packages:

FWCore/Services

@smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@nclopezo
Copy link
Contributor

+1
the errors in the unit tests are the ones that were already in the IB:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1056/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Oct 29, 2013
Multithreading fixes -- Made SimpleMemoryCheck thread-safe
@ktf ktf merged commit fb4044c into cms-sw:CMSSW_7_0_X Oct 29, 2013
zhenbinwu pushed a commit to zhenbinwu/cmssw that referenced this pull request Feb 28, 2024
Add Phase-2 Level-1 LLP trigger emulator: TOoLLiP [14_0_0_pre3]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants