Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hcal fraction to packed candidates (76X) #12132

Merged

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Oct 27, 2015

Save hcal energy fraction for pf candidates corresponding to neutral hadrons in the tracker (pdgId 130) or in the HF (pdgId 1).
The energy fraction is packed with an absolute precision of 1%. We will evaluate later if the precision can be reduced for CMSSW_8_0_X, depending on what we'll learn in CMSSW_7_6_X.
From @mariadalfonso after discussion with @arizzi and @bachtis

The branch merges cleanly also in CMSSW_8_0_X, if you need a separate PR it can be made.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_6_X.

Add hcal fraction to packed candidates (76X)

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

cmsbuild, please test

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9321/console

@Dr15Jones
Copy link
Contributor

The variable needs to be assigned in the copy and move constructors and the assignment operators.

@Dr15Jones
Copy link
Contributor

Hold

@cmsbuild cmsbuild added the hold label Oct 29, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@gpetruc
Copy link
Contributor Author

gpetruc commented Oct 30, 2015

Updated copy and move constructors and assignment operators.
Sorry I hadn't even realized that those methods had been added in the 76X
version of this class

Giovanni

On Thu, Oct 29, 2015 at 11:00 AM, cmsbuild notifications@github.com wrote:

Comparison is ready

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12132/9321/summary.html


Reply to this email directly or view it on GitHub
#12132 (comment).

@cmsbuild
Copy link
Contributor

Pull request #12132 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9360/console

davidlange6 added a commit that referenced this pull request Oct 30, 2015
…based

Add hcal fraction to packed candidates (76X)
@davidlange6 davidlange6 merged commit a9dd2b3 into cms-sw:CMSSW_7_6_X Oct 30, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@gpetruc gpetruc deleted the maria_packedNeutralfraction_rebased branch June 1, 2016 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants