Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring JSON changes in DAQ #12136

Merged
merged 3 commits into from Nov 3, 2015
Merged

Conversation

smorovic
Copy link
Contributor

Changes:

  • migrating to JSON based format for module legend used by f3mon
  • adding HLTErrorEvents field which will used to distinguish between losses caused by crashes in CMSSW and other reasons, for example hardware failures.

…M DB

with additional information that distinguishes errors from crashes in
HLT farm and other, purely DAQ related causes)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_5_X.

Monitoring JSON changes in DAQ

It involves the following packages:

DQMServices/Components
EventFilter/Utilities
HLTrigger/JSONMonitoring

@perrotta, @cmsbuild, @cvuosalo, @fwyzard, @emeschi, @Martin-Grunewald, @deguio, @slava77, @mommsen, @vanbesien, @danduggan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mommsen
Copy link
Contributor

mommsen commented Oct 28, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9257/console

@fwyzard
Copy link
Contributor

fwyzard commented Oct 28, 2015

+1

@fwyzard
Copy link
Contributor

fwyzard commented Oct 28, 2015

HLT change looks reasonable

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Oct 28, 2015

+1

@cvuosalo
Copy link
Contributor

+1

For #12136 b9ccbe9

Changes in the monitoring JSON for the DAQ. #12137 and #12138 are the 76X and 80X versions of this PR.

The code changes are OK for 75X. The 80X version of this PR will require some small code changes for maintainability. Jenkins tests against baseline CMSSW_7_5_X_2015-10-27-2300 show no significant differences.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 3, 2015
@cmsbuild cmsbuild merged commit 3b482ee into cms-sw:CMSSW_7_5_X Nov 3, 2015
@smorovic smorovic deleted the jsonlegends-75X branch November 13, 2015 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants