New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fillDescriptions migration and parameter cleanup in DAQ modules (80X) #12148
Conversation
*ShmStreamConsumer as legacy name remains defined in ShmStreamConsumer_cfi.py
…LEASE_BASE and local path). Parameters for this definition are no longer exported. *file prefixes for fast and slow monitoring do not need to be configurable
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_8_0_X. fillDescriptions migration and parameter cleanup in DAQ modules (80X) It involves the following packages: EventFilter/Utilities @mommsen, @cvuosalo, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks. |
The jenkins tests job failed, please try again. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
…f the former is not found
@cmsbuild please test |
The tests are being triggered in jenkins. |
I applied updates based on some of the changes. Here is a summary of those that still remain: Dereference of null pointer in ExceptionGenerator.cc non-const global static variables in crc32c.cc: non-const (global) static variable in json_value.cpp "inherits from edm::EDProducer,edm::EDFilter,edm::EDAnalyzer, or edm::OutputModule" non-const static variable in EventFilter/Utilities/plugins/RawEventFileWriterForBU.cc const_cast used on a pointer to a data class EventFilter /Utilities/src /json_value.cpp Also I modifies this one, but static checker still complains: |
+1 |
@smorovic: It looks like you may have missed a simple const problem in FastMonitoring.cc, line 116:
Won't |
@cvuosalo, |
+1 fillDescriptions migration in DAQ modules. #12146 and #12147 are the 75X and 76X versions of this PR, and they have already been approved by Reco. #12245 has a fixed version of FastMonitoringService.cc that should take precedence over the version of this file in this PR. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2015-11-02-2300 show no significant differences. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
I was taking into account that these changes merge together (also git is smart to take into account "git mv" when it's merged with other commits). Usually also git doesn't silently revert changes, but produces conflicts. In my tests all three merges fine. If any conflict pops up, I will rebase as necessary. |
+1 |
fillDescriptions migration and parameter cleanup in DAQ modules (80X)
Changes:
Port of #12146 (75X) and #12147 (76X)