Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level-1 Trigger changes for HI Firmware (76X backport of #12176) #12180

Merged

Conversation

harmonicoscillator
Copy link
Contributor

76X backport of #12176

R. Alex Barbieri added 30 commits July 20, 2015 22:25
In addition, switch from vector of doubles to LUT for PUM0 table.
…s-l1t-offline

* cms-l1t-offline/l1t-devel-CMSSW_7_6_0_pre1-CaloParamsUpdate:
  Refactor CaloParams into CaloParamsHelper

Conflicts:
	L1Trigger/L1TCalorimeter/src/PUSubtractionMethods.cc
	L1Trigger/L1TCalorimeter/src/firmware/Stage1Layer2JetAlgorithmImpHI.cc
	L1Trigger/L1TCalorimeter/src/firmware/Stage1Layer2SingleTrackHI.cc
* richard-cms/HIL1_FirmwareMatching_760p7:
  build fixes
  commit current HI status, will move to pre7 shortly
  use correct CaloParams values for HI algos
  centrality verbosity changes
  reorganize single track algo
  egamma verbosity and also iso/non-iso swap
  updates to verbosity for egammas
  change the verbosity
  use a tunable mask to zero the walls
  change verbosity levels
  switch to integer division
  switch back to 3x3 jet finder for tests
  turn on high verbosity for HI algos
  Refactor CaloParams into CaloParamsHelper

Conflicts:
	L1Trigger/L1TCalorimeter/test/SimL1Emulator_Stage1.py
* richard-cms/HIL1_FirmwareMatching_760p7:
  build fixes
  commit current HI status, will move to pre7 shortly
  use correct CaloParams values for HI algos
  centrality verbosity changes
  reorganize single track algo
  egamma verbosity and also iso/non-iso swap
  updates to verbosity for egammas
  change the verbosity
  use a tunable mask to zero the walls
  change verbosity levels
  switch to integer division
  switch back to 3x3 jet finder for tests
  turn on high verbosity for HI algos
  Refactor CaloParams into CaloParamsHelper
* richard-cms/HIL1_FirmwareMatching_760p7: (26 commits)
  do not set node version manually, remove PUSParam LUT
  fix CaloParamsHelper so that multiple setting of masks doesn't break things
  extended centrality fixes
  fixes for extended centrality
  fix egamma HI bug
  don't forget new LUT file:
  switch MB trigger to use parameters
  extend centrality algo and add alternative MB algo
  reduce verbosity
  fix typo
  remove background subtraction for ETT for HI running
  switch to new HI parameters instead of overloading old ones
  build fixes
  commit current HI status, will move to pre7 shortly
  use correct CaloParams values for HI algos
  centrality verbosity changes
  reorganize single track algo
  egamma verbosity and also iso/non-iso swap
  updates to verbosity for egammas
  change the verbosity
  ...
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2015

@ggovi
Copy link
Contributor

ggovi commented Dec 8, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

cmsbuild, please test
(the comparisons are gone)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10430/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2016

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 6, 2016
  Level-1 Trigger changes for HI Firmware (76X backport of #12176)
@cmsbuild cmsbuild merged commit 80b99b1 into cms-sw:CMSSW_7_6_X Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants