Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum to PackedCandidate and functions to MiniFloatConverter to aid validation #12226

Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Nov 2, 2015

This PR changes PackedCandidate to use enum instead of magic constants for track hit masks and shifts, and adds bunch of std::numeric_limits style functions to MiniFloatConverter (+unit tests for those). I need both for upcoming improvements in PackedCandidateTrackValidator (which I prefer to integrate separately to show that the changes here do not affect results).

Tested in 760pre3 and rebased on top of CMSSW_8_0_X_2015-10-28-1100. No changes expected in monitored quantities.

@rovere @VinInn @arizzi @gpetruc

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

Add enum to PackedCandidate and functions to MiniFloatConverter to aid validation

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@makortel
Copy link
Contributor Author

makortel commented Nov 6, 2015

ping

@arizzi
Copy link
Contributor

arizzi commented Nov 6, 2015

I think this is ok with me and @gpetruc but we are not the one expected to sign off in github

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9506/console

davidlange6 added a commit that referenced this pull request Nov 7, 2015
Add enum to PackedCandidate and functions to MiniFloatConverter to aid validation
@davidlange6 davidlange6 merged commit 50230de into cms-sw:CMSSW_8_0_X Nov 7, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2015

@makortel makortel deleted the packedCandidateForValidation branch October 20, 2016 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants