Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for compatible mode in UETableProducer. Don't overwrite pytho… #12227

Merged
merged 1 commit into from Nov 4, 2015

Conversation

mverwe
Copy link
Contributor

@mverwe mverwe commented Nov 2, 2015

…n files in make_db.sh.
Does not have impact on reconstruction. Bug fix for DB generation.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

A new Pull Request was created by @mverwe (Marta Verweij) for CMSSW_7_5_X.

Bug fix for compatible mode in UETableProducer. Don't overwrite pytho

It involves the following packages:

RecoHI/HiJetAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @jazzitup, @richard-cms, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Nov 2, 2015

@cmsbuild please test
... jenkins is down though, unclear if this message will be queued or just missed

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9415/console

@smuzaffar
Copy link
Contributor

@slava77 , jenkins is up again but web access via cmssdt is not configured yet
Any, cms bot should see these messages and trigger the tests properly

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

@slava77
Copy link
Contributor

slava77 commented Nov 2, 2015

@mverwe
please make a PR in 76X (80X will get it by auto-forward-port from 76X).

@mverwe
Copy link
Contributor Author

mverwe commented Nov 3, 2015

@slava77
PR for 76X made: #12239

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 3, 2015

+1

For #12227 581060b

Bug fix in Heavy Ion UETableProducer for DB generation. There should be no change in monitored quantities. #12239 is the 76X version of this PR.

The code change is satisfactory, though thread safety will need to be addressed in the 76X version. Jenkins tests against baseline CMSSW_7_5_X_2015-11-01-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 4, 2015
Bug fix for compatible mode in UETableProducer. Don't overwrite pytho…
@cmsbuild cmsbuild merged commit 8cf1cbe into cms-sw:CMSSW_7_5_X Nov 4, 2015
cmsbuild added a commit that referenced this pull request Nov 5, 2015
Bug fix for compatible mode in UETableProducer. (Same as #12227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants