New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected wrong cfi file called for PhaseIPixel tag in dumpSimGeometry_cfg.py #12236
Conversation
A new Pull Request was created by @friccita (Francesca Ricci-Tam) for CMSSW_7_6_X. corrected wrong cfi file called for PhaseIPixel tag in dumpSimGeometry_cfg.py It involves the following packages: Fireworks/Geometry @cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks. |
I will take the opportunity of his PR to suggest for this PR or a subsequent one to remove the super obsolete Tracker scenarios , I see at least three of them in this file to be removed :
Thanks |
Pull request #12236 was updated. @cmsbuild, @alja, @Dr15Jones can you please check and sign again. |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
corrected wrong cfi file called for PhaseIPixel tag in dumpSimGeometry_cfg.py
In dumpSimGeometry_cfg.py, the wrong cfi.py file was being loaded for the PhaseIPixel tag; I have changed it to the correct filename.