Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected wrong cfi file called for PhaseIPixel tag in dumpSimGeometry_cfg.py #12236

Merged
merged 2 commits into from Nov 8, 2015

Conversation

friccita
Copy link
Contributor

@friccita friccita commented Nov 3, 2015

In dumpSimGeometry_cfg.py, the wrong cfi.py file was being loaded for the PhaseIPixel tag; I have changed it to the correct filename.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

A new Pull Request was created by @friccita (Francesca Ricci-Tam) for CMSSW_7_6_X.

corrected wrong cfi file called for PhaseIPixel tag in dumpSimGeometry_cfg.py

It involves the following packages:

Fireworks/Geometry

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@boudoul
Copy link
Contributor

boudoul commented Nov 3, 2015

I will take the opportunity of his PR to suggest for this PR or a subsequent one to remove the super obsolete Tracker scenarios , I see at least three of them in this file to be removed :

elif score == "Phase1_R34F16":
    process.load('Geometry.CMSCommonData.Phase1_R34F16_cmsSimIdealGeometryXML_cff')

elif score == "Phase2Tk":
   process.load('Geometry.CMSCommonData.cmsExtendedGeometryPhase2TkBEXML_cfi')

elif score == "SLHC":    process.load('SLHCUpgradeSimulations.Geometry.Phase1_R30F12_HCal_cmsSimIdealGeometryXML_cff')

Thanks
Gaelle

@boudoul
Copy link
Contributor

boudoul commented Nov 3, 2015

Thanks @friccita
@cmsbuild please aknowledge changes

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

Pull request #12236 was updated. @cmsbuild, @alja, @Dr15Jones can you please check and sign again.

@alja
Copy link
Contributor

alja commented Nov 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9481/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 8, 2015
corrected wrong cfi file called for PhaseIPixel tag in dumpSimGeometry_cfg.py
@cmsbuild cmsbuild merged commit 22dca51 into cms-sw:CMSSW_7_6_X Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants