Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phase1 pixel and Phase2 (2023) eras #12254

Merged
merged 1 commit into from Nov 5, 2015

Conversation

mark-grimes
Copy link

Previously opened on #12169 for 7_6_X. As discussed in 03/Nov release planning meeting this should be in 8_0_X only so #12169 will be closed. Description from there:

Add a Run2_2017 era that includes the Phase 1 pixel detector; and a Phase2Dev era for every Phase2 component that currently works in 76X. I'm not entirely convinced by the name Phase2Dev, if anyone wants it changed please comment here.

Put in on 7_6_X, not sure if it should be 8_0_X only?

Currently no changes added to either scenario, I thought integration would be easier if that was done in separate pull requests. Note that this includes #12124 otherwise there would probably be merge conflicts (EDIT - now no longer true; decoupled from #12124).

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_8_0_X.

Add Phase1 pixel and Phase2 (2023) eras

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9453/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2015

davidlange6 added a commit that referenced this pull request Nov 5, 2015
Add Phase1 pixel and Phase2 (2023) eras
@davidlange6 davidlange6 merged commit af4aac5 into cms-sw:CMSSW_8_0_X Nov 5, 2015
@mark-grimes mark-grimes deleted the addPhase1AndPhase2Eras branch November 5, 2015 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants