Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phase1Pixel era digitisation additions #12275

Merged

Conversation

mark-grimes
Copy link

First tranche of phase1Pixel era additions. I'll try and split these down by package to make them easier to integrate. This one is for the digitisation.

There should be no change whatsoever unless the Run2_2017 era is active (the only top-level era that contains phase1Pixel).

The change to the import in the pixelDigitizer_cfi.py file is for technical reasons, otherwise the pileup dependent inefficiency is not applied. Depending on how #12256 pans out this might be able to be removed (will do that later though).

Tests might fail until the next IB - requires #12254 which has only just been merged. Not sure if the relevant commit will be included automatically.

@boudoul, @atricomi

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_8_0_X.

phase1Pixel era digitisation additions

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

davidlange6 added a commit that referenced this pull request Nov 12, 2015
@davidlange6 davidlange6 merged commit 4c0e50f into cms-sw:CMSSW_8_0_X Nov 12, 2015
@mark-grimes mark-grimes deleted the phase1PixelEraDigiChanges branch November 13, 2015 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants