phase1Pixel era digitisation additions #12275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First tranche of
phase1Pixel
era additions. I'll try and split these down by package to make them easier to integrate. This one is for the digitisation.There should be no change whatsoever unless the
Run2_2017
era is active (the only top-level era that containsphase1Pixel
).The change to the import in the pixelDigitizer_cfi.py file is for technical reasons, otherwise the pileup dependent inefficiency is not applied. Depending on how #12256 pans out this might be able to be removed (will do that later though).
Tests might fail until the next IB - requires #12254 which has only just been merged. Not sure if the relevant commit will be included automatically.
@boudoul, @atricomi