Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with pythia8 212 and features from 76X #12286

Merged
2 commits merged into from Nov 17, 2015

Conversation

mkirsano
Copy link
Contributor

@mkirsano mkirsano commented Nov 6, 2015

No description provided.

@mkirsano
Copy link
Contributor Author

mkirsano commented Nov 6, 2015

To be built with cmsdist #1946

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2015

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for CMSSW_7_5_X.

Compatibility with pythia8 212 and features from 76X

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2015

-1
Tested at: beb642e
I found an error when building:

--- Registered EDM Plugin: GeneratorInterfaceCascadeInterface
>> Leaving Package GeneratorInterface/CascadeInterface
>> Package GeneratorInterface/CascadeInterface built
>> Building shared library tmp/slc6_amd64_gcc491/src/FastSimulation/ParticleDecay/src/FastSimulationParticleDecay/libFastSimulationParticleDecay.so
Copying tmp/slc6_amd64_gcc491/src/FastSimulation/ParticleDecay/src/FastSimulationParticleDecay/libFastSimulationParticleDecay.so to productstore area:
/build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_5_X_2015-11-05-2300/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc:79:28: error: 'string' was not declared in this scope
   std::map > knownDecayModes;
                            ^
/build/cmsbuild/jenkins-workarea/workspace/test-cmsdist-cmssw-test-pr/CMSSW_7_5_X_2015-11-05-2300/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc:79:28: note: suggested alternatives:
In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/volA/slc6_amd64_gcc491/external/gcc/4.9.1-cms/include/c++/4.9.1/iosfwd:39:0,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/volA/slc6_amd64_gcc491/external/gcc/4.9.1-cms/include/c++/4.9.1/memory:72,


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12286/15/summary.html

@ghost
Copy link

ghost commented Nov 6, 2015

@mkirsano (writing again) After a manual double check I confirm that's a legitimate error found by the new script that tests this cmssw PR against the cmsdist one.

@mkirsano
Copy link
Contributor Author

mkirsano commented Nov 6, 2015

Somehow this was not needed in other branches.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2015

Pull request #12286 was updated. @vciulli, @civanch, @covarell, @lveldere, @ssekmen, @mdhildreth, @cmsbuild, @thuer, @bendavid, @govoni can you please check and sign again.

@ghost
Copy link

ghost commented Nov 7, 2015

@mkirsano I'll trigger the (custom) tests again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2015

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#1946

@lveldere
Copy link
Contributor

lveldere commented Nov 9, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

@cmsbuild
Copy link
Contributor

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@ghost
Copy link

ghost commented Nov 13, 2015

@davidlange6 should we proceed with the merging of this one along its cmsdist part?

@cmsbuild
Copy link
Contributor

ghost pushed a commit that referenced this pull request Nov 17, 2015
Compatibility with pythia8 212 and features from 76X
@ghost ghost merged commit f112127 into cms-sw:CMSSW_7_5_X Nov 17, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants