Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hi relvals #12360

Merged
merged 2 commits into from Nov 11, 2015
Merged

Fix hi relvals #12360

merged 2 commits into from Nov 11, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 10, 2015

This is a carry forward of pull request #12303 to CMSSW_8_0_X. This PR fixes relval tests 300, 301, and 302.

@wmtan
Copy link
Contributor Author

wmtan commented Nov 10, 2015

@davidlange6 This is the fix for relvals 300, 301, and 302 carried forward into 8_0_X, so it does not have to wait until this goes into 7_6_X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_8_0_X.

Fix hi relvals

It involves the following packages:

GeneratorInterface/HiGenCommon
PhysicsTools/HepMCCandAlgos
SimGeneral/MixingModule
SimMuon/GEMDigitizer

@vciulli, @civanch, @covarell, @mdhildreth, @monttj, @cmsbuild, @thuer, @bendavid, @vadler, @govoni can you please review it and eventually sign? Thanks.
@cbaus, @mkirsano, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@wmtan
Copy link
Contributor Author

wmtan commented Nov 10, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9636/console

@cmsbuild
Copy link
Contributor

-1
Tested at: e558345
When I ran the RelVals I found an error in the following worklfows:
25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 10-Nov-2015 20:20:14 CET-----------------------
An exception of category 'NotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'validation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootEmbeddedFileSequence::readOneSpecified(): Secondary Input files do not contain specified event:
run: 1 lumi: 74 event: 22061
----- End Fatal Exception -------------------------------------------------

1000.0 step1

DAS Error

1001.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12360/9636/summary.html

@wmtan
Copy link
Contributor Author

wmtan commented Nov 11, 2015

I cannot reproduce the error in 25202. It could also be caused by a DAS error.

@wmtan
Copy link
Contributor Author

wmtan commented Nov 11, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9647/console

@cmsbuild
Copy link
Contributor

-1
Tested at: e558345
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

4.22 step1

DAS Error

1000.0 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12360/9647/summary.html

@wmtan
Copy link
Contributor Author

wmtan commented Nov 11, 2015

Again, these errors have nothing to do with this PR.

davidlange6 added a commit that referenced this pull request Nov 11, 2015
@davidlange6 davidlange6 merged commit 2944a91 into cms-sw:CMSSW_8_0_X Nov 11, 2015
@wmtan wmtan deleted the FixHIRelvals branch November 16, 2015 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants