Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail read calls after exception. (same as #12590) #12593

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Nov 30, 2015

If a read call was performed after XrdFile threw an exception, it
is possible there are no active sources. However, not all paths
check for the case of zero sources and may use-after-free the last
source.

This caused a deadlock at the Tier-0.

If a read call was performed after XrdFile threw an exception, it
is possible there are no active sources.  However, not all paths
check for the case of zero sources and may use-after-free the last
source.

This caused a deadlock at the Tier-0.
@slava77
Copy link
Contributor Author

slava77 commented Nov 30, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Nov 30, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10006/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_6_X.

It involves the following packages:

Utilities/XrdAdaptor

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented Nov 30, 2015

merge
to keep the technical fix in sync across releases

cmsbuild added a commit that referenced this pull request Nov 30, 2015
@cmsbuild cmsbuild merged commit 621692f into cms-sw:CMSSW_7_6_X Nov 30, 2015
@Dr15Jones
Copy link
Contributor

+1
#12608

@Dr15Jones
Copy link
Contributor

Will this be automerged into CMSSW_8_0?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@slava77
Copy link
Contributor Author

slava77 commented Nov 30, 2015

it is in 80X now
621692f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants