Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CSCHaloData to AOD, which was inadvertently deleted by PR 11068 #12631

Merged
merged 1 commit into from Dec 3, 2015

Conversation

cvuosalo
Copy link
Contributor

@cvuosalo cvuosalo commented Dec 2, 2015

#11068 was intended as a simple clean-up to replace certain wildcards in keep statements with explicit strings, but in the process a keep statement for recoCSCHaloData was accidentally deleted in RecoMET_EventContent_cff.py. This PR restores this missing CSC halo data to AOD.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for CMSSW_7_6_X.

It involves the following packages:

RecoMET/Configuration

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Dec 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10057/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Dec 2, 2015

+1

For #12631 81f5446

Restoring CSC halo data to AOD. There should be no change in monitored quantities.

Jenkins tests against baseline CMSSW_7_6_X_2015-12-01-1100 show no significant differences, as expected. Additional tests show that the CSC halo data has been restored to the AOD event content, while there is no change to the RECO or Mini-AOD content.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 3, 2015
Restore CSCHaloData to AOD, which was inadvertently deleted by PR 11068
@cmsbuild cmsbuild merged commit 0360c4e into cms-sw:CMSSW_7_6_X Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants