Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating online info application 8_0 #12640

Merged
merged 3 commits into from Dec 8, 2015
Merged

Updating online info application 8_0 #12640

merged 3 commits into from Dec 8, 2015

Conversation

vanbesien
Copy link
Contributor

No description provided.

@vanbesien
Restructure info config + remove l1GtEvm Unpacking
6ef4334
@vanbesien
Complete rewrite of the info module
5e2f497 
Made the code readable again.
Restructured and removed invalid parts.
Changed logic to make it more safe in certain conditions.
Investigated and hid the missing beamstatus.
(Discussed long term solution with Jeroen)
@vanbesien
(Re)did the kCanRebin to kAllAxes change for root6
5f72203
@vanbesien
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Dec 2, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10082/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

A new Pull Request was created by @vanbesien (Broen van Besien) for CMSSW_8_0_X.

It involves the following packages:

DQM/Integration
DQMServices/Components

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic, @threus, @batinkov this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

+1
Tested at: 5f72203
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12640/10082/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12640/10082/summary.html

@deguio
Copy link
Contributor

deguio commented Dec 7, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 8, 2015
@cmsbuild
Merge pull request #12640 from vanbesien/updating_online_info_applica…
ebeb0b1 
…tion_port

Updating online info application 8_0
@cmsbuild cmsbuild merged commit ebeb0b1 into cms-sw:CMSSW_8_0_X Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vanbesien @cmsbuild @deguio @davidlange6