Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include HI menu in 75X #12644

Merged
merged 30 commits into from Dec 8, 2015
Merged

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Dec 2, 2015

This pull request integrates the HLT menu for the HI runs of 2015, as it will be saved for future runs and used for the HI MC production.

The HI menus fir CMSSW_7_5_X are not yet complete, because we still miss the one for the pp reference runs at 5 TeV. A dedicated pull request will be prepared as soon as ready.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

A new Pull Request was created by @perrotta for CMSSW_7_5_X.

It involves the following packages:

Configuration/HLT
FastSimulation/Tracking
HLTrigger/Configuration

@perrotta, @cmsbuild, @civanch, @lveldere, @ssekmen, @mdhildreth, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @matt-komm, @geoff-smith, @jalimena, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@slava77
Copy link
Contributor

slava77 commented Dec 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10097/console

@perrotta
Copy link
Contributor Author

perrotta commented Dec 2, 2015

+1

@diguida
Copy link
Contributor

diguida commented Dec 2, 2015

@perrotta please take my commit with the following commands from your release:

$ git remote add diguida https://github.com/diguida/cmssw.git
$ git fetch diguida
$ git checkout includeHImenuIn75X
$ git cherry-pick 11dd190

@diguida
Copy link
Contributor

diguida commented Dec 2, 2015

and then push:

git push my-cmssw includeHImenuIn75X

HTH

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

Pull request #12644 was updated. @perrotta, @cmsbuild, @civanch, @diguida, @lveldere, @ssekmen, @mdhildreth, @Martin-Grunewald, @franzoni, @cerminar, @fwyzard, @mmusich, @davidlange6 can you please check and sign again.

@perrotta
Copy link
Contributor Author

perrotta commented Dec 2, 2015

@diguida : done, thanks!

@perrotta
Copy link
Contributor Author

perrotta commented Dec 2, 2015

(Now tests should get restarted...)

@perrotta
Copy link
Contributor Author

perrotta commented Dec 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10099/console

@perrotta
Copy link
Contributor Author

perrotta commented Dec 4, 2015

cherry-picked your last commit (difference with previous here in last 28ae940)

@perrotta
Copy link
Contributor Author

perrotta commented Dec 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10155/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2015

@Martin-Grunewald
Copy link
Contributor

+1

@diguida
Copy link
Contributor

diguida commented Dec 6, 2015

+1

@Martin-Grunewald
Copy link
Contributor

Hi , @lveldere, @ssekmen @civanch
Could you please sign for fastsim?
Thanks!

@civanch
Copy link
Contributor

civanch commented Dec 6, 2015

+1
from my point of view it is minimally concern of FastSim

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 8, 2015
@cmsbuild cmsbuild merged commit bd3022d into cms-sw:CMSSW_7_5_X Dec 8, 2015
@perrotta perrotta deleted the includeHImenuIn75X branch December 9, 2015 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants