New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not call TTree cache after an exception happens #12662
Do not call TTree cache after an exception happens #12662
Conversation
Since TTree is not exception safe, we must avoid calling TTree methods after we have had an exception thrown through TTree. Normally this happens when one thread throws an exception while another thread is waiting to access the same TTree. This should avoid crashes seen in the Tier 0.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X. It involves the following packages: IOPool/Input @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
-1 DAS Error 134.911 step1 DAS Error 140.53 step1 DAS Error you can see the results of the tests here: |
Failures are not from this pull request |
…tion_7_6 Do not call TTree cache after an exception happens
Since TTree is not exception safe, we must avoid calling TTree methods after we have had an exception thrown through TTree. Normally this happens when one thread throws an exception while another thread is waiting to access the same TTree.
This should avoid crashes seen in the Tier 0.