Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion in JER code #12723

Merged
merged 2 commits into from Dec 21, 2015
Merged

Conversation

blinkseb
Copy link
Contributor

@blinkseb blinkseb commented Dec 9, 2015

The first commit fix an infinite recursion happening when the code wants to throw an exception.

Second commit update the demo code to add rho to the list of parameters, needed for latest JER payloads.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2015

A new Pull Request was created by @blinkseb (Sébastien Brochet) for CMSSW_8_0_X.

It involves the following packages:

CondFormats/JetMETObjects
JetMETCorrections/Modules

@ggovi, @vadler, @cmsbuild, @davidlange6, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @apfeiffer1, @schoef, @mariadalfonso this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@diguida
Copy link
Contributor

diguida commented Dec 14, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10283/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Dec 21, 2015
Fix infinite recursion in JER code
@davidlange6 davidlange6 merged commit c636ab4 into cms-sw:CMSSW_8_0_X Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants