Throw on unrunnable schedule

[wmtan]

Throw an exception if the schedule is not runnable due to cyclic dependencies, instead of just logging an error message.

[cmsbuild]

A new Pull Request was created by @wmtan for CMSSW_8_0_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10312/console

[Dr15Jones]

@davidlange6 When would you like this to be the standard? It is possible to have this throw an exception for a scheduled job which would happen to work (but that same job converted to unscheduled would fail).

[cmsbuild]

+1
Tested at: b366706
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12763/10312/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12763/10312/summary.html

[davidlange6]

@Dr15Jones - sorry I missed this question before the holidays. Could we discuss it tomorrow in a core sw meeting?

[Dr15Jones]

@davidlange6 As per request from the Core meeting, the magic string to look for in the log file is

Module run order problem found:

[davidlange6]

ok - unless my script is broken, this string does not appear in the IBs.. lets test it.

On Jan 5, 2016, at 10:17 PM, Chris Jones notifications@github.com wrote:

@davidlange6 As per request from the Core meeting, the magic string to look for in the log file is

Module run order problem found:

—
Reply to this email directly or view it on GitHub.

[Dr15Jones]

thanks