Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning of input PackedCandidates in PuppiProducer when using existing Puppi weights #12851

Conversation

ferencek
Copy link
Contributor

This PR extends the PuppiProducer code so that it clones the input PackedCandidates when the existing Puppi weights are used, i.e., when MiniAOD is used as input.

In addition, a switch was added that enables cloning of PackedCandidates even when one wants to re-run the Puppi algorithm on MiniAOD instead of using the existing Puppi weights.

All of these changes are relevant for retaining the track-related information embedded in PackedCandidates which makes it possible to run b tagging from Puppi jets and Puppi-weighted PackedCandidates.

@imarches @rappoccio @nhanvtran

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_8_0_X.

It involves the following packages:

CommonTools/PileupAlgos

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@slava77
Copy link
Contributor

slava77 commented Dec 29, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10403/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Dec 30, 2015

+1

for #12851 dab4cdf

  • code changes are in line with the description
  • jenkins tests pass and comparisons with baseline show no differences (the miniAOD-kind processing is tested; running from miniAOD is not tested in jenkins tests, AFAIK).

davidlange6 added a commit that referenced this pull request Jan 1, 2016
…Cands_from-CMSSW_8_0_0_pre4

Cloning of input PackedCandidates in PuppiProducer when using existing Puppi weights
@davidlange6 davidlange6 merged commit 05a3a70 into cms-sw:CMSSW_8_0_X Jan 1, 2016
@ferencek ferencek deleted the PuppiProducer-ClonedPackedCands_from-CMSSW_8_0_0_pre4 branch January 4, 2016 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants