Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivial static fixes for thread safety for CalibCalorimetry #1286

Merged
merged 2 commits into from Nov 7, 2013
Merged

Trivial static fixes for thread safety for CalibCalorimetry #1286

merged 2 commits into from Nov 7, 2013

Conversation

nclopezo
Copy link
Contributor

@nclopezo nclopezo commented Nov 1, 2013

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2013

A new Pull Request was created by @nclopezo (David Mendez) for CMSSW_7_0_X.

Trivial static fixes for thread safety for CalibCalorimetry

It involves the following packages:

CalibCalorimetry/EcalLaserAnalyzer
CalibCalorimetry/EcalLaserSorting

@demattia, @nclopezo, @rcastello can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

ktf
ktf reviewed Nov 1, 2013
View reviewed changes
CalibCalorimetry/EcalLaserAnalyzer/src/TSFit.cc
@@ -274,7 +274,7 @@ double TSFit::fit_third_degree_polynomial(
double xki2;
double tm, tmp, amp;

static double nevt;
double nevt;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change the behaviour. nevt is incremented every time the function is called. Given this is crap in any case, and not used anywhere, I guess you can just drop it...

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2013

Pull request #1286 was updated. @demattia, @nclopezo, @rcastello can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2013

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1178/summary.html

@ktf
Copy link
Contributor

ktf commented Nov 7, 2013

Bypassing AlCa signature...

ktf added a commit that referenced this pull request Nov 7, 2013
@ktf
Merge pull request #1286 from nclopezo/threadSafetyStaticsCalibCalori…
8cdd0ac 
…metry

Multithreading fixes -- Trivial static fixes for thread safety for CalibCalorimetry
@ktf ktf merged commit 8cdd0ac into cms-sw:CMSSW_7_0_X Nov 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nclopezo @cmsbuild @ktf