New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added updateJetCollection() function to jetTools.py and related changes to the PATJetUpdater and the pat::Jet class #12863
Conversation
A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_8_0_X. It involves the following packages: DataFormats/PatCandidates @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@@ -1,6 +1,6 @@ | |||
import FWCore.ParameterSet.Config as cms | |||
|
|||
patJetsUpdated = cms.EDProducer("PATJetUpdater", | |||
updatedPatJets = cms.EDProducer("PATJetUpdater", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this renaming invisible to users (affects only transient objects)?
If it is not, why change the name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, with the updateJetCollection() function from jetTools.py, this becomes a transient collection. Also, the new name is more in line with the PAT jet naming convention where user-defined labels and postfixes come after "PatJets" while "updated" is a fixed prefix-type descriptor.
The tests are being triggered in jenkins. |
@slava77, PR subject line updated |
+1
|
…rovedPATbtagESLoading_from-CMSSW_8_0_0_pre4 Added updateJetCollection() function to jetTools.py and related changes to the PATJetUpdater and the pat::Jet class
…rovedPATbtagESLoading_from-CMSSW_8_0_0_pre4
This PR builds on top of #8288 and adds the updateJetCollection() function to jetTools.py. This function allows, in a user-friendly way, to update the jet energy corrections and re-run existing or add additional b-tag discriminators. It can also be used to add TagInfos to jets. It primarily targets updating pat::Jets stored in MiniAOD. In addition, users can manually add an arbitrary set of additional userFloats.
An example cfg file
PhysicsTools/PatAlgos/test/patTuple_updateJets_fromMiniAOD_cfg.py
was also added and included in PAT unit tests.One caveat concerns added TagInfos. They cannot be successfully retrieved from pat::Jets stored in the existing MiniAOD datasets due to a bug in the
PATJetSlimmer
which was not clearing thetagInfoLabels_
data member of thepat::Jet
class when dropping the TagInfos from slimmed jets. This PR therefore also includes a required bugfix for thePATJetSlimmer
.@ahinzmann @imarches @gpetruc @arizzi