HCAL TP Lut generation: skip DetIds that can't be converted to HcalDetIds.

[matz-e]

When using hardcoded LUT metadata, not all DetIds returned by lutMetadata.getAllChannels() are trigger tower ones. Safeguard against ZDC Ids that may be in said collection.

[cmsbuild]

A new Pull Request was created by @matz-e (Matthias Wolf) for CMSSW_8_0_X.

It involves the following packages:

CalibCalorimetry/CaloTPG

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10428/console

[cmsbuild]

+1
Tested at: 89c6dc3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12866/10428/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12866/10428/summary.html

[mmusich]

+1
for matz-e@89c6dc3

[mulhearn]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar