Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCal DB Parameters Writer #12888

Merged
merged 3 commits into from Jan 13, 2016
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jan 7, 2016

  • HGCal DB parameters writer implemented
  • HGCal DB parameters analyzer and test configuration

To write them out locally and read them back:

cmsRun CondTools/Geometry/test/hgcalgeometrywriter.py
cmsRun Geometry/HGCalCommonData/test/hgcalParameters_cfg.py

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2016

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_0_X.

It involves the following packages:

CondCore/GeometryPlugins
CondCore/Utilities
CondFormats/GeometryObjects
CondTools/Geometry
Configuration/Geometry
DataFormats/ForwardDetId
Geometry/CaloGeometry
Geometry/CaloTopology
Geometry/HGCalCommonData
Geometry/HGCalGeometry
Geometry/Records
RecoLocalCalo/HGCalRecProducers
SimCalorimetry/HGCalSimProducers
SimDataFormats/CaloTest
SimG4CMS/Calo

@civanch, @diguida, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @slava77, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @vandreev11, @sethzenz, @makortel, @apfeiffer1, @kpedro88, @lgray, @cseez, @pfs, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@ianna
Copy link
Contributor Author

ianna commented Jan 8, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10445/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

Pull request #12888 was updated. @civanch, @diguida, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @slava77, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Jan 8, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10449/console

@slava77
Copy link
Contributor

slava77 commented Jan 8, 2016

@ianna
#12862 is already merged. It is included in this PR as well and triggers extra signatures/labels. Please remove the parts already in #12862

@ianna
Copy link
Contributor Author

ianna commented Jan 8, 2016

@slava77 - yes, it's another branch based on #12862. As soon as an IB is available, I'll rebase this one.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2016

@cmsbuild
Copy link
Contributor

Pull request #12888 was updated. @civanch, @diguida, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jan 11, 2016

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ggovi
Copy link
Contributor

ggovi commented Jan 12, 2016

+1

@mmusich
Copy link
Contributor

mmusich commented Jan 12, 2016

+1

@ianna
Copy link
Contributor Author

ianna commented Jan 12, 2016

+1

@civanch
Copy link
Contributor

civanch commented Jan 12, 2016

+1
In workflow 5.1 (FastSIm for run1) there is a problem in HcalHitsV - many nans, it is likely not directly related

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Jan 13, 2016
@davidlange6 davidlange6 merged commit 6b616ea into cms-sw:CMSSW_8_0_X Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants