New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added updateJetCollection() function to jetTools.py and related changes to the PATJetUpdater and the pat::Jet class (76X) #12890
Added updateJetCollection() function to jetTools.py and related changes to the PATJetUpdater and the pat::Jet class (76X) #12890
Conversation
A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_7_6_X. It involves the following packages: DataFormats/PatCandidates @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1
|
No, it does not. This is an optional feature not enabled in the MiniAOD production. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1
|
…_7_6_3 Added updateJetCollection() function to jetTools.py and related changes to the PATJetUpdater and the pat::Jet class (76X)
@@ -3,13 +3,13 @@ | |||
from PhysicsTools.PatAlgos.recoLayer0.jetCorrections_cff import * | |||
from PhysicsTools.PatAlgos.producersLayer1.jetUpdater_cfi import * | |||
|
|||
patJetCorrFactorsUpdated = patJetCorrFactors.clone( | |||
updatedPatJetCorrFactors = patJetCorrFactors.clone( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this name is changed? which doesn't seem to be necessary since the contents of this module is not changed.. This change of module name will require all physics analyses that need to re-applying the new 76x JEC using this module to do some unnecessary change of their analysis codes.
For example, for our H->ZZ->4l analysis framework, the following line need to be changed if we want to change from 763patch2 to 764:
https://github.com/CJLST/ZZAnalysis/blob/miniAOD_76X/AnalysisStep/test/MasterPy/ZZ4lAnalysis.py#L1007
but this doesn't seem to be necessary...
@hengne, have you seen https://twiki.cern.ch/twiki/bin/view/CMSPublic/WorkBookJetEnergyCorrections#CorrPatJets, in particular https://github.com/cms-sw/cmssw/blob/CMSSW_7_6_X/PhysicsTools/PatAlgos/test/patTuple_updateJets_fromMiniAOD_cfg.py Now you can use the |
@ferencek |
@hengne, I see your point. The main idea here was to simplify things for users and introduce the |
@ferencek OK, i see. Maybe a HN announcement of this change would be useful? The 764 is just built a couple of days ago, I think more and more analyses will try 764 in the following days. They might meet the same crash as we seen in H4l. A HN announcement may save some debugging time for many analyses. Thanks! |
@hengne, done, here it is https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3457.html Thanks for the suggestion. |
@ferencek Thanks! |
Partial backport of #12863 (updates to the PATJetSlimmer excluded since they would affect the MiniAOD event content by changing the internal content of slimmed jets).
Update (Jan. 14, 2016): Added backport of #12953