Make lockTracks passed by reference

[lgray]

Fix PFEGammaFilter JetMET checks to ensure that tracks are locked when they should be.

This may cause fluctuations in JetMET tails.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10496/console

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_0_X.

It involves the following packages:

RecoParticleFlow/PFProducer

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[cmsbuild]

+1
Tested at: a7e5d8a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12942/10496/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12942/10496/summary.html

[cvuosalo]

+1

For #12942 a7e5d8a

Bug fix for PFEGammaFilter JetMET checks to ensure that tracks are locked when they should be.

The code fix is satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-01-13-2300 show no significant differences. An extended test of workflow 1338.0_QCD_FlatPt_15_3000 with 200 events against baseline CMSSW_8_0_X_2016-01-05-2300 also shows no significant differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1