Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDF weight helper tool (80x, updated) #13019

Merged
merged 4 commits into from Jan 29, 2016

Conversation

bendavid
Copy link
Contributor

To be used at analysis level to apply the mc2hessian procedure on the fly for analysis needing hessian-type uncertainties from existing samples with mc replica-like weights.

(replaces #12787)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/HepMCCandAlgos

@cmsbuild, @vadler, @davidlange6, @monttj can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@bendavid
Copy link
Contributor Author

@davidlange6 do you also want me to change the legacy class inheritance in the corresponding 74x and 76x backports?

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10687/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1
@bendavid - would be best to have the back ports consistent with this one -yes. Thanks

davidlange6 added a commit that referenced this pull request Jan 29, 2016
Add PDF weight helper tool (80x, updated)
@davidlange6 davidlange6 merged commit 5bc0097 into cms-sw:CMSSW_8_0_X Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants