Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soureek updating TOP trigger Pathnames according to CMSHLT-666 #13027

Merged

Conversation

soureek
Copy link

@soureek soureek commented Jan 21, 2016

The following paths have been renamed according to [1] as suggested in [2]
HLT_Ele23_WPLoose_Gsf_CentralPFJet30_BTagCSV07_v2
HLT_Ele27_WPLoose_Gsf_CentralPFJet30_BTagCSV07_v1
HLT_Ele32_eta2p1_WPLoose_Gsf_CentralPFJet30_BTagCSV07_v2
HLT_IsoMu18_CentralPFJet30_BTagCSV07_v2
HLT_IsoMu22_CentralPFJet30_BTagCSV07_v2
HLT_IsoMu24_eta2p1_CentralPFJet30_BTagCSV07_v4

[1] https://docs.google.com/spreadsheets/d/1jQbCdbkrsoirLJ9_UvN-xEvjYbtPnHqRHKDwwB8iHFg/edit#gid=0
[2] https://its.cern.ch/jira/browse/CMSHLT-666

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Soureek89 (Soureek Mitra) for CMSSW_8_0_X.

It involves the following packages:

DQMOffline/Trigger
HLTriggerOffline/Top

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@deguio
Copy link
Contributor

deguio commented Jan 22, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10676/console

@deguio
Copy link
Contributor

deguio commented Jan 22, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: 6bbc963
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 22-Jan-2016 10:38:33 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 22-Jan-2016 10:45:32 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 22-Jan-2016 10:45:55 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

134.911 step3

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log
----- Begin Fatal Exception 22-Jan-2016 10:46:28 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 22-Jan-2016 10:47:19 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
----- Begin Fatal Exception 22-Jan-2016 10:48:45 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 22-Jan-2016 10:50:47 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 22-Jan-2016 10:52:54 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 22-Jan-2016 10:54:15 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log
----- Begin Fatal Exception 22-Jan-2016 10:54:53 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 22-Jan-2016 10:56:31 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 22-Jan-2016 11:04:57 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 22-Jan-2016 11:08:50 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TopSingleLeptonHLTOfflineDQM label='SingleTopSingleMuonHLTOfflineDQM'
Exception Message:
MissingParameter: VParameterSet 'selection' not found.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13027/10676/summary.html

…hon/ to correct the errors obtained by tests triggered by jenkins
@cmsbuild
Copy link
Contributor

Pull request #13027 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@soureek
Copy link
Author

soureek commented Jan 22, 2016

I have corrected for the errors obtained during tests triggered by jenkins. I tested the code by running the matrix for TTbar events. Test results show the following message.

25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED - time date Fri Jan 22 15:20:45 2016-date Fri Jan 22 15:04:02 2016; exit: 0 0 0 0 0
1 1 1 1 1 tests passed, 0 0 0 0 0 failed

Please cross-check again for any possible update.

@deguio
Copy link
Contributor

deguio commented Jan 25, 2016

please test

@deguio
Copy link
Contributor

deguio commented Jan 25, 2016

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10710/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1
would be easier to maintain these arrays of strings if they were put into an array once and then used instead of being repeated two times

cmsbuild added a commit that referenced this pull request Jan 25, 2016
…eChange

Soureek updating TOP trigger Pathnames according to CMSHLT-666
@cmsbuild cmsbuild merged commit e84f06a into cms-sw:CMSSW_8_0_X Jan 25, 2016
cmsbuild added a commit that referenced this pull request Jan 25, 2016
@soureek soureek deleted the Soureek_Jan21_TriggerPathNameChange branch January 25, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants