Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of modules used in PbPb HLT to do ZeroSuppression to "stream" modules in 80X #13053

Merged
merged 1 commit into from Jan 27, 2016

Conversation

Martin-Grunewald
Copy link
Contributor

Migration of modules used in PbPb HLT to do ZeroSuppression to stream modules in 80X
Forward port of #12419

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_8_0_X.

It involves the following packages:

EventFilter/RawDataCollector
EventFilter/SiStripRawToDigi

@cvuosalo, @emeschi, @cmsbuild, @slava77, @mommsen, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @VinInn this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10718/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor Author

@emeschi, @mommsen
please sign this PR.
Thanks!

@Martin-Grunewald
Copy link
Contributor Author

@cvuosalo, @slava77
please sign this PR.
Thanks!

@cvuosalo
Copy link
Contributor

+1

For #13053 ae0622a

Migrating modules that do PbPb HLT ZeroSuppression to support thread safety. There should be no change in monitored quantities. #12415 is the 75X version of this PR, and it was already merged last year.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-01-24-2300 show no significant differences, as expected.

@mommsen
Copy link
Contributor

mommsen commented Jan 27, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 27, 2016
Migration of modules used in PbPb HLT to do ZeroSuppression to "stream" modules in 80X
@cmsbuild cmsbuild merged commit fa8eb4d into cms-sw:CMSSW_8_0_X Jan 27, 2016
@Martin-Grunewald Martin-Grunewald deleted the MTport branch January 28, 2016 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants