MET PAT tool update + update of MET significance #13115

mmarionncern · 2016-01-28T19:16:06Z

This PR contains the following changes :

fix several tiny bugs in the MET tool (e.g. JECs were not properly propagated when only reapplied on slimmed jets, met significance set to zero arbitrary in the wrong constructor)
revisits the jet smearing code
enable the jet smearing and its propagation to the MET
revisits the MET unclustered energy uncertainties with detector based resolution instead of the ad-hoc 10%
uniformize the jet selection for Type1MET correction and MET JES uncertainties
enable the use of DB JER numbers for teh MET significance and jet smearing
fix the scheduled mode of the PAT MET tool

======= /!\ IMPORTANT NOTICE /!\ =========

Jet energy resolution values are now available in the database, but not yet stored in it. and those values are used in the jet smearing and in the met significance computation. In the lack of GT containing a JetResolutionRcd entry, all tests (runTheMatrix or standard tests) involving a PAT process will fail if it touches the MET tool.

Packages involved :

DataFormats/METReco
DataFormats/PatCandidates
JetMETCorrections/Modules
JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
RecoMET/METAlgorithms
RecoMET/METProducers

Changes expected :

very tiny change in CPU consumption due the MET significance computation
MET significance is now computed in the central pat::MET
tiny change expected in the slimmedMET/ patPFMetType1 pT values due to the uniformization of cleaning (removal of overlaps selected/slimmed muons and electrons)
unclustered uncertainties changed
smeared MET not set to the central value anymore
JER uncertainties accessible if someone uses the smeared MET

cmsbuild · 2016-01-28T19:16:56Z

A new Pull Request was created by @mmarionncern for CMSSW_8_0_X.

It involves the following packages:

DataFormats/PatCandidates
JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
RecoMET/METAlgorithms
RecoMET/METProducers

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @TaiSakuma, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-01-28T19:27:07Z

JetMETCorrections/Type1MET/interface/JetCleanerForType1METT.h

+      {
+	token_ = consumes<std::vector<T> >(cfg.getParameter<edm::InputTag>("src"));
+
+	if ( cfg.exists("offsetCorrLabel") ) {


cfg.exists can be used only in exceptional cases (e.g. there is a large number of existing configs to be modified or the parameter is interpreted by a remotely called helper class).
Please use fillDescriptions method
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideConfigurationValidationAndHelp

slava77 · 2016-01-28T20:01:57Z

@mmarionncern
when should we expect the GT?
If I understood your message correctly, if we runTheMatrix.py -l limited -i all, the steps with PAT will now fail.

slava77 · 2016-01-28T20:02:51Z

@cmsbuild please test
(there are enough code changes so that the static analysis would be useful, even though it sounds like the code will fail run time)

cmsbuild · 2016-01-28T20:03:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10829/console

mmarionncern · 2016-01-28T20:12:40Z

@slava77 the GT should come soon, this has been set to the highest priority by the JetMET people. And yes, the runTheMatrix step in PAT will fail

cmsbuild · 2016-01-28T22:13:01Z

-1

Tested at: e4ca7a3
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13115/10829/summary.html

schoef · 2016-01-29T04:59:40Z

GT has been requested by Sebastian
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2212.html

mmusich · 2016-01-29T10:08:25Z

assign alca

mmusich · 2016-01-29T18:03:23Z

@mmarionncern the requested Global Tags (for MC) are ready:
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2212/2/1/1/1.html

80X_mcRun2_design_v3
As 80X_mcRun2_design_v2 with:
additions of 8 labels for JetResolutionRcdand 4 labels for JetResolutionScaleFactorRcd
80X_mcRun2_asymptotic_v3
As 80X_mcRun2_asymptotic_v2 with:
additions of 8 labels for JetResolutionRcd and 4 labels for JetResolutionScaleFactorRcd
80X_mcRun2_startup_v3
As 80X_mcRun2_startup_v2 with:
additions of 8 labels for JetResolutionRcdand 4 labels for JetResolutionScaleFactorRcd

Please update your branch chaging the relevant keys of Configuration/AlCa/autoCond.py

slava77 · 2016-01-29T19:00:43Z

There are problems running the tests unrelated to GT

An exception of category 'WrongPluginLoaded' occurred while
   [0] Constructing the EventProcessor
Exception Message:
The plugin 'JetCorrectionESChain' should have been loaded from
 '/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-27-2300/lib/slc6_amd64_gcc493/pluginPhysicsToolsPatAlgos_plugins.so'
 but instead it was already loaded from
 '/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-01-27-2300/lib/slc6_amd64_gcc493/pluginRecoLocalCaloHcalRecAlgosPlugin.so'
 because some other plugin was loaded from the latter loadables.
To work around the problem the plugin 'JetCorrectionESChain' should only be defined in one of these loadables.
----- End Fatal Exception -------------------------------------------------

It looks like JetMETCorrections/Modules/src containing plugins is the problem.
All files (and headers for them) that define plugins (ES/EDProducers) should be collected in the plugins/ directory; things go unexpectedly bad when they are in /src and /plugins.

cmsbuild · 2016-03-10T00:54:49Z

Pull request #13115 was updated. @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please check and sign again.

slava77 · 2016-03-10T02:23:39Z

@cmsbuild please test

cmsbuild · 2016-03-10T02:24:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11811/console

cmsbuild · 2016-03-10T04:35:09Z

+1
Tested at: 1f1c606
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13115/11811/summary.html

cmsbuild · 2016-03-10T05:31:09Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13115/11811/summary.html

slava77 · 2016-03-10T08:14:16Z

+1

for #13115 1f1c606

code changes are somewhat in line with the description (plus the puppi for MET updates mentioned towards the end of the thread). Changes affect only miniAOD products.
jenkins tests pass and comparisons with baseline show rather minor changes in puppi MET and in puppi Jet quantities: in the jets the changes are driven by the reduction of the threshold to 15 GeV
technical performance was checked earlier in MET PAT tool update + update of MET significance #13115 (comment) : CPU increase is small
- all new modules and different copies of jets and candidates introduced by new modules (~100 modules selecting/shifting/smearing jets/leptons/candidates) correspond to about 67 MB/thread increase in memory of miniAOD-only application (my 8-thread test had ~540MB increase in RSS). It's probably OK now (it doesn't look like a leak, just a baseline increase).
tested locally on ttbar PU35 ~1.5K events: the tail in MET introduced in the next-to-last iteration is gone together with the change in HFEM ET fraction
- The kinematic plots are the same as the ones shown in MET PAT tool update + update of MET significance #13115 (comment)
- NaNs in DQM plots for pf-specific MET fractions and energies are gone as well as in MET unclustered uncertainty values

slava77 · 2016-03-10T08:25:05Z

@davidlange6 this so far is the last large PR with 80X miniAOD changes

slava77 · 2016-03-10T13:24:58Z

I looked at the memory with one thread now. All of the ~500MB are here as well, not plainly proportional per thread.
This may start killing RelVals.
I'm going to look in more details.
It sounds like the saga is not over yet.

slava77 · 2016-03-10T19:08:26Z

@davidlange6
Fix to the memory issue reported in #13115 (comment)
is resolved in #13682

MET PAT tool update + update of MET significance

cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 28, 2016

cmsbuild added reconstruction-pending analysis-pending pending-signatures tests-pending orp-pending comparison-pending labels Jan 28, 2016

slava77 reviewed Jan 28, 2016
View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2016

cmsbuild added tests-rejected and removed tests-started labels Jan 28, 2016

mmusich mentioned this pull request Feb 1, 2016

Updating e/gamma Mustache SuperCluster regressions for 80X #13141

Merged

add fix along Phil's suggestion

1f1c606

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Mar 10, 2016

cmsbuild added tests-started and removed tests-pending labels Mar 10, 2016

cmsbuild added tests-approved and removed tests-started labels Mar 10, 2016

cmsbuild added comparison-available and removed comparison-pending labels Mar 10, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 10, 2016

This was referenced Mar 10, 2016

delete loaded cleanPatJets after the temporary load if it was not around already #13681

Merged

delete loaded cleanPatJets after the temporary load if it was not around already (same as #13681 ) #13682

Merged

davidlange6 added a commit that referenced this pull request Mar 17, 2016

Merge pull request #13115 from cms-met/METCorDev_Jan16_METSig

6c4b6cd

MET PAT tool update + update of MET significance

davidlange6 merged commit 6c4b6cd into cms-sw:CMSSW_8_0_X Mar 17, 2016

mmarionncern mentioned this pull request Mar 30, 2016

Fix JEC updater for MET correction in 76X #13865

Merged

ferencek mentioned this pull request Apr 6, 2016

JEC fix in the PATJetUpdater (76X backport) #13970

Merged

slava77 mentioned this pull request Apr 18, 2016

Backport of puppi changes from 80X to 76X #13975

Merged

slava77 mentioned this pull request Sep 7, 2016

Puppi Photon update see PR 15429 #15562

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MET PAT tool update + update of MET significance #13115

MET PAT tool update + update of MET significance #13115

mmarionncern commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

slava77 Jan 28, 2016

slava77 commented Jan 28, 2016

slava77 commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

mmarionncern commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

schoef commented Jan 29, 2016

mmusich commented Jan 29, 2016

mmusich commented Jan 29, 2016

slava77 commented Jan 29, 2016

cmsbuild commented Mar 10, 2016

slava77 commented Mar 10, 2016

cmsbuild commented Mar 10, 2016

cmsbuild commented Mar 10, 2016

cmsbuild commented Mar 10, 2016

slava77 commented Mar 10, 2016

slava77 commented Mar 10, 2016

slava77 commented Mar 10, 2016

slava77 commented Mar 10, 2016

MET PAT tool update + update of MET significance #13115

MET PAT tool update + update of MET significance #13115

Conversation

mmarionncern commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

slava77 Jan 28, 2016

Choose a reason for hiding this comment

slava77 commented Jan 28, 2016

slava77 commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

mmarionncern commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

schoef commented Jan 29, 2016

mmusich commented Jan 29, 2016

mmusich commented Jan 29, 2016

slava77 commented Jan 29, 2016

cmsbuild commented Mar 10, 2016

slava77 commented Mar 10, 2016

cmsbuild commented Mar 10, 2016

cmsbuild commented Mar 10, 2016

cmsbuild commented Mar 10, 2016

slava77 commented Mar 10, 2016

slava77 commented Mar 10, 2016

slava77 commented Mar 10, 2016

slava77 commented Mar 10, 2016