Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim: enable noise and beamhalo info #13179

Merged
merged 2 commits into from Feb 9, 2016
Merged

FastSim: enable noise and beamhalo info #13179

merged 2 commits into from Feb 9, 2016

Conversation

lveldere
Copy link
Contributor

@lveldere lveldere commented Feb 3, 2016

removing some unnecessary fastsim modes

@lveldere
Copy link
Contributor Author

lveldere commented Feb 3, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10982/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

A new Pull Request was created by @lveldere for CMSSW_8_0_X.

It involves the following packages:

FastSimulation/Configuration
PhysicsTools/PatAlgos

@civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @Martin-Grunewald, @jdolen, @nhanvtran, @matt-komm, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@lveldere
Copy link
Contributor Author

lveldere commented Feb 3, 2016

some issues left,
closing for now

@lveldere lveldere closed this Feb 3, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

@lveldere lveldere reopened this Feb 4, 2016
@lveldere
Copy link
Contributor Author

lveldere commented Feb 4, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10997/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

Pull request #13179 was updated. @civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

@slava77
Copy link
Contributor

slava77 commented Feb 4, 2016

+1

for #13179 98d9d6a

  • changes in the code are in line with the description; the changes affect only FastSim
  • jenkins tests pass and comparisons with baseline show no differences in monitored physics objects
  • looking at local copies of the jenkins jobs shows no difference in data workflow output (134.911 checked) and that beam halo and jet association products now show up in the outputs of the fastsim step1 (135.4 checked), consistent with the code changes. The following are added in
    135.4 (ZEE FS) step1
recoHcalHaloData_HcalHaloData__HLT.
recoHcalNoiseRBXs_hcalnoise__HLT.
HcalNoiseSummary_hcalnoise__HLT.
recoJet%TorecoTrack%AssociationVector_ak4JetTracksAssociatorExplicit__HLT.
recoEcalHaloData_EcalHaloData__HLT.

@lveldere
Copy link
Contributor Author

lveldere commented Feb 8, 2016

+1

@lveldere
Copy link
Contributor Author

lveldere commented Feb 9, 2016

ping @Analysis
thanks

davidlange6 added a commit that referenced this pull request Feb 9, 2016
FastSim: enable noise and beamhalo info
@davidlange6 davidlange6 merged commit 4a9dde7 into cms-sw:CMSSW_8_0_X Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants