Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-functional support of unique_ptr in produce_helpers. #13182

Merged
merged 1 commit into from Feb 4, 2016

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 3, 2016

A very recent PR was added that included the addition of a template to produce_helpers in an attempt to support the use of unique_ptr in this context. This addition was not sufficient to support unique_ptr here, and may mislead users to believe that it is supported. As adding support for unique_ptr in produce_helpers is non-trivial, we just back this out for now so that users will not be mislead.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

A new Pull Request was created by @wmtan for CMSSW_8_0_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10984/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

-1

Tested at: 89c0e99
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13182/10984/summary.html

@Dr15Jones
Copy link
Contributor

The unit test failure is not related to this pull request.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

davidlange6 added a commit that referenced this pull request Feb 4, 2016
Remove non-functional support of unique_ptr in produce_helpers.
@davidlange6 davidlange6 merged commit ec1fee3 into cms-sw:CMSSW_8_0_X Feb 4, 2016
@wmtan wmtan deleted the RemoveNonfunctionalCode branch February 5, 2016 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants