New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-functional support of unique_ptr in produce_helpers. #13182
Conversation
A new Pull Request was created by @wmtan for CMSSW_8_0_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
-1 Tested at: 89c0e99 ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
The unit test failure is not related to this pull request. |
Remove non-functional support of unique_ptr in produce_helpers.
A very recent PR was added that included the addition of a template to produce_helpers in an attempt to support the use of unique_ptr in this context. This addition was not sufficient to support unique_ptr here, and may mislead users to believe that it is supported. As adding support for unique_ptr in produce_helpers is non-trivial, we just back this out for now so that users will not be mislead.