Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add condition formats corresponding to L1T global UTM library #13202

Merged
merged 4 commits into from Feb 5, 2016
Merged

add condition formats corresponding to L1T global UTM library #13202

merged 4 commits into from Feb 5, 2016

Conversation

mulhearn
Copy link
Contributor

@mulhearn mulhearn commented Feb 5, 2016

Provides the Cond Formats needed by L1T Global for use with the new UTM library.

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Feb 5, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

CondFormats/L1TObjects

@diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11016/console

@mulhearn mulhearn mentioned this pull request Feb 5, 2016
Closed
@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

+1

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

Update underway for CondCore and CondFormats/DataRecord, but these will be totally vanilla.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

Pull request #13202 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

+1
Tested at: 8087801
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13202/11016/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
08a989f
6129747
7c335d8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13202/11016/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13202/11016/git-merge-result

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

I just noticed, I think we had best define the std::vector/maps as type blob.... one last update coming with that.

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

OK that should do it...

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

Pull request #13202 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

please test

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11024/console

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

Update: in my local compilation testSerialization passed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13202/11016/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

+1
Tested at: fdda5a1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13202/11024/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4e72b79
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13202/11024/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13202/11024/git-merge-result

@ggovi
Copy link
Contributor

ggovi commented Feb 5, 2016

+1

@mmusich
Copy link
Contributor

mmusich commented Feb 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13202/11024/summary.html

davidlange6 added a commit that referenced this pull request Feb 5, 2016
@davidlange6
Merge pull request #13202 from cms-l1t-offline/pr-utm-condformats-80x
1337765 
add condition formats corresponding to L1T global UTM library
@davidlange6 davidlange6 merged commit 1337765 into cms-sw:CMSSW_8_0_X Feb 5, 2016
cmsbuild added a commit that referenced this pull request Feb 5, 2016
@cmsbuild
Merge pull request #13202 from cms-l1t-offline/pr-utm-condformats-80x
d273b66
@mulhearn mulhearn mentioned this pull request Feb 6, 2016
Merged
@mulhearn mulhearn deleted the pr-utm-condformats-80x branch February 11, 2016 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available db-approved fully-signed l1-approved orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mulhearn @cmsbuild @ggovi @mmusich @davidlange6