Hit Skipping in Track Candidate producer #13214
Conversation
|
A new Pull Request was created by @Ansh0712 (Anshul Kapoor) for CMSSW_8_0_X. It involves the following packages: FastSimulation/Tracking @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
| recHitCandidates.push_back(seedHit); | ||
| } | ||
| bool passedLastSeedHit = false; | ||
| const FastTrackerRecHit * lastSeedHit = recHitCandidates.back().hit(); |
There was a problem hiding this comment.
not safe for hitless seeds
and for hitless seeds we need
passedLastSeedHits = true
|
Pull request #13214 was updated. @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 >> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-07-2300/src/FastSimulation/Tracking/plugins/TrackCandidateProducer.cc
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-07-2300/src/FastSimulation/Tracking/plugins/TrajectorySeedProducer.cc
>> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-07-2300/src/Utilities/StaticAnalyzers/src/EDMPluginDumper.cc
>> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-07-2300/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-07-2300/src/FastSimulation/Tracking/plugins/TrackCandidateProducer.cc: In member function 'virtual void TrackCandidateProducer::produce(edm::Event&, const edm::EventSetup&)':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-07-2300/src/FastSimulation/Tracking/plugins/TrackCandidateProducer.cc:158:31: error: unused variable 'lastSeedHit' [-Werror=unused-variable]
const FastTrackerRecHit \* lastSeedHit = recHitCandidates.back().hit();
^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-07-2300/src/FastSimulation/Tracking/plugins/TrackCandidateProducer.cc:165:24: error: 'lastSeedHit' was not declared in this scope
if(seed.nHits()==0||lastSeedHit->sameId(currentTrackerHit.hit()))
^
you can see the results of the tests here: |
|
Pull request #13214 was updated. @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
|
Pull request #13214 was updated. @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
|
please test |
1 similar comment
|
please test |
|
The tests are being triggered in jenkins. |
|
could you validate this once more, exactly as it is right now? |
|
Everything looks fine to me. Here are the validation plots for the latest version: |
|
+1 thanks @Ansh0712 |
cmsbuild
added
fastsim-approved
fully-signed
and removed
fastsim-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Hit Skipping in Track Candidate producer
Hits skipped by seed are also skipped by track.
Number of crossed layers check was also removed.