Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-hcx66 Changes to Simulation for 2016++ scenario #13255

Merged
merged 6 commits into from Feb 16, 2016

Conversation

bsunanda
Copy link
Contributor

Some fixes to HcalTopology and HcalDDDRecConstants
Fix Full and Fast Sim for multianode readout of HF

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/ShowerDevelopment
Geometry/CaloTopology
Geometry/HcalCommonData
SimG4CMS/Calo

@civanch, @Dr15Jones, @lveldere, @ianna, @mdhildreth, @cmsbuild, @ssekmen, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm, @ghellwig, @makortel this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11150/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 696ffc9
I found an error when building:

--- Registered EDM Plugin: testCaloSimHits
>> Building shared library tmp/slc6_amd64_gcc493/src/CalibCalorimetry/CaloTPG/src/CalibCalorimetryCaloTPG/libCalibCalorimetryCaloTPG.so
>> Building shared library tmp/slc6_amd64_gcc493/src/CalibCalorimetry/HcalAlgos/src/CalibCalorimetryHcalAlgos/libCalibCalorimetryHcalAlgos.so
--- Registered EDM Plugin: SimG4CMSCaloPlugins
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-02-11-1100/external/slc6_amd64_gcc493/lib/libboost_date_time.so: file not recognized: Bad address
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc493/src/CondTools/Geometry/plugins/CondToolsGeometryPlugins/libCondToolsGeometryPlugins.so] Error 1
>> Building shared library tmp/slc6_amd64_gcc493/src/CalibCalorimetry/CastorCalib/src/CalibCalorimetryCastorCalib/libCalibCalorimetryCastorCalib.so
Leaving library rule at src/SimG4CMS/ShowerLibraryProducer/plugins
@@@@ Running edmWriteConfigs for testCaloTowerGeometryESProducer
--- Registered EDM Plugin: testCaloTowerGeometryESProducer


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13255/11150/summary.html

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11153/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13255/11153/summary.html

There are some workflows for which there are errors in the baseline:
4.22 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11198/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

@civanch @ianna @mdhildreth @ssekmen We would like to have this in 8_0_0 release and approved by tomorrow. Could you kindly to review this and have it approved

@lveldere
Copy link
Contributor

+1

thanks Sunanda

@ianna
Copy link
Contributor

ianna commented Feb 15, 2016

+1

@civanch
Copy link
Contributor

civanch commented Feb 15, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 16, 2016
bsunanda:Run2-hcx66 Changes to Simulation for 2016++ scenario
@cmsbuild cmsbuild merged commit a6d52e4 into cms-sw:CMSSW_8_0_X Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants