Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLTElectronMuonInvMassFilter update #13257

Merged
merged 3 commits into from Feb 21, 2016

Conversation

gpasztor
Copy link
Contributor

The HLTElectronMuonInvariantMassFilter code is modified to accept also RecoEcalCandidate - Muon pairs in addition to Electron - Muon. Modification made and tested by Matt Carver (following the suggestion of @matteosan1 ).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpasztor for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/Egamma

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11151/console

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

Since we now get more possible objects, the accept rate will go up.
Has this been studied on signal and esp. background (HLT rate)?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13257/11151/summary.html

There are some workflows for which there are errors in the baseline:
4.22 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@matteosan1
Copy link
Contributor

Hi Martin,
as far as I know there will never be a a mixed situation where you can can
pair to muons, electrons or photons.
The change has been done to let few paths to cope with the new EGM
convention which propagate down the path just RecoEcalCandidate: see for
example HLT_Mu8_Ele8_CaloIdM_GsfTrackIdM_Mass8_PFHT300

Regards,
Matteo.

+++++++++++
Matteo Sani
University of California, San Diego, US.
Tel: +41227671577
CERN Office: 40-3-A02

On Fri, Feb 12, 2016 at 8:24 AM, Martin Grunewald notifications@github.com
wrote:

Since we now get more possible objects, the accept rate will go up.
Has this been studied on signal and esp. background (HLT rate)?


Reply to this email directly or view it on GitHub
#13257 (comment).

@Martin-Grunewald
Copy link
Contributor

+1
OK, thanks for the clarification.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@@ -102,8 +115,18 @@ HLTElectronMuonInvMassFilter::hltFilter(edm::Event& iEvent, const edm::EventSetu
pElectron.push_back( pThisEle );
eleCharge.push_back( refele->charge() );
}

for(unsigned int i=0;i<clusCands.size();i++){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use reserve on pElectron and eleCharge to pre-allocate the memory here.
(eg, pElectron.reserve(clusCands.size()); )

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@Martin-Grunewald
Copy link
Contributor

@davidlange6
What is holding up this PR?

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11408/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 21, 2016
HLTElectronMuonInvMassFilter update
@cmsbuild cmsbuild merged commit bafbcf9 into cms-sw:CMSSW_8_0_X Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants