New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLTElectronMuonInvMassFilter update #13257
Conversation
A new Pull Request was created by @gpasztor for CMSSW_8_0_X. It involves the following packages: HLTrigger/Egamma @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
Since we now get more possible objects, the accept rate will go up. |
Comparison is ready There are some workflows for which there are errors in the baseline: |
Hi Martin, Regards, +++++++++++ On Fri, Feb 12, 2016 at 8:24 AM, Martin Grunewald notifications@github.com
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@@ -102,8 +115,18 @@ HLTElectronMuonInvMassFilter::hltFilter(edm::Event& iEvent, const edm::EventSetu | |||
pElectron.push_back( pThisEle ); | |||
eleCharge.push_back( refele->charge() ); | |||
} | |||
|
|||
for(unsigned int i=0;i<clusCands.size();i++){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use reserve on pElectron and eleCharge to pre-allocate the memory here.
(eg, pElectron.reserve(clusCands.size()); )
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@davidlange6 |
please test |
The tests are being triggered in jenkins. |
+1 |
HLTElectronMuonInvMassFilter update
The HLTElectronMuonInvariantMassFilter code is modified to accept also RecoEcalCandidate - Muon pairs in addition to Electron - Muon. Modification made and tested by Matt Carver (following the suggestion of @matteosan1 ).