BugFix for TwinMux unpacker - change of logic involved

[jpazzini]

• check beginning/end of AMC stream using HEX of header/trailer -> moved to 4 bit [was 6 for header, 8 for trailer]

-  int BOEevTy  = ( dataWord >> 56 ) & 0xFf;  // positions 60 -> 63
+  int BOEevTy  = ( dataWord >> 60 ) & 0xF;  // positions 60 -> 63

-  if ( (BOEevTy != 0x51) || ( TM7fedId != twinMuxFed ) ) {
+  if ( (BOEevTy != 0x5) || ( TM7fedId != twinMuxFed ) ) {

+  int chkEOE = (dataWord >> 60 ) & 0xF;  // positions 60 -> 63
+  if ( chkEOE != 0xA ) {
+      edm::LogWarning("TwinMux_unpacker") << "AMC block closing line " << std::hex << dataWord 
+                                          << std::dec << " does not start with 0xA";
+      return;
+  }

• range of AMC blocks to be read -> changed to 1-12 [was 0-11]

-    if ( AMCno < 12 ) {
-      AMCsizes[AMCno] = ( dataWord >> 32 ) & 0xFFFFFF;  // positions 32 -> 55
+    if ( (AMCno < 1) || (AMCno > 12) ) {
+        edm::LogWarning("TwinMux_unpacker") << "AMCnumber " << std::dec << AMCno 
+                                            << " out of range (1-12)";
+        return;
+    }    

• TM payload -> payload stored according to the expected size from the headers [was until the stream start with the trailer HEX (0xA) ]

-  while ( chkEOE != 0xA0 ) { 
[...] (store TM payloads)
-}

+  ///--> Store payloads
+  std::map<int,int>::iterator AMCiterator = AMCsizes.begin();
+  std::map<int,int>::iterator AMCitend = AMCsizes.end();  
+  for ( ; AMCiterator != AMCitend; ++AMCiterator ) {
+      
+    for ( int k=0; k<AMCiterator->second; ++k) {
+        
+       readline( nline, dataWord );
+       calcCRC( dataWord, newCRC);
+       DTTM7WordContainer.push_back( dataWord );
+     }
+  }  

[cmsbuild]

A new Pull Request was created by @jpazzini for CMSSW_8_0_X.

It involves the following packages:

EventFilter/L1TXRawToDigi

The following packages do not have a category, yet:

EventFilter/L1TXRawToDigi

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[mulhearn]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11204/console

[mulhearn]

+1

[mulhearn]

@jpazzini: please add a summary to help this sail through.

[mulhearn]

This will be needed during MWGR in order to unpack correctly the TwinMux for DQM.

[jpazzini]

@mulhearn - added some details about the commit in the first comment

[cmsbuild]

+1
Tested at: 5a07ce1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13278/11204/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13278/11204/summary.html