Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused arguments from printCmsExceptionWarning #13292

Merged

Conversation

Dr15Jones
Copy link
Contributor

The optional arguments to printCmsExceptionWarning where never used so they have been removed.

The optional arguments to printCmsExceptionWarning where never used so they have been removed.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

FWCore/MessageLogger

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11229/console

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1

Tested at: 4908f97
I found errors in the following unit tests:

---> test runtestSimCalorimetryHGCalSimProducers had ERRORS
---> test testRecoMETMETProducers had ERRORS
---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13292/11229/summary.html

@Dr15Jones
Copy link
Contributor Author

None of the unit test failures were caused by this pull request.

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Feb 16, 2016
…ning

Removed unused arguments from printCmsExceptionWarning
@davidlange6 davidlange6 merged commit 7ce1d56 into cms-sw:CMSSW_8_0_X Feb 16, 2016
@Dr15Jones Dr15Jones deleted the simplifyPrintCmsExceptionWarning branch March 28, 2016 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants