Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation module for ME0 Detector (Phase2 Upgrade) #13347

Merged

Conversation

cmsbuild
Copy link
Contributor

Validation module for ME0 Detector (Phase2 Upgrade)

This PR involve a new version of the ME0 validation package. Now all the modules are in the same packages, defined as a plugins.

  • MuonGEMHits plugin is related to SimHit on ME0 Detector.
  • MuonGEMDigis plugin is related to Digi step about ME0.
  • MuonGEMRecHits plugin is related both to ME0 RecHits and ME0 Segments.

This PR does not affect other modules.

These module are only run by a specific customize options. (Validation/MuonME0Validation/python/me0Custom.py)
Automatically ported from CMSSW_8_0_X #13325 (original by @clacaputo).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_8_1_X.

It involves the following packages:

Validation/MuonME0Validation

The following packages do not have a category, yet:

Validation/MuonME0Validation

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@calabria
Copy link
Contributor

Are there any news about this PR? Can we go on with the review? Please, consider that this package is waiting since 75X... moreover the review was already complete in 800 (before we were asked to combine the 3 modules in just one package). Please, let us know. Thanks.

@smuzaffar
Copy link
Contributor

@calabria, which cmssw category should be responsible for this new package Validation/MuonME0Validation ... is it dqm?

@davidlange6
Copy link
Contributor

yes, DQM

On Mar 24, 2016, at 11:28 AM, Malik Shahzad Muzaffar notifications@github.com wrote:

@calabria, which cmssw category should be responsible for this new package Validation/MuonME0Validation ... is it dqm?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@calabria
Copy link
Contributor

@smuzaffar yes, even though this package is new. Anyway it was already discussed last year at one of the DQM meetings.

@cmsbuild
Copy link
Contributor Author

Pull request #13347 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Mar 24, 2016

please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12049/console

@deguio
Copy link
Contributor

deguio commented Mar 24, 2016

+1
this code was reviewed back in Dec (PR #11941) and looks ok.

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 10d3272 into cms-sw:CMSSW_8_1_X Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants