Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase1 customs #13357

Merged
merged 4 commits into from Mar 2, 2016
Merged

Phase1 customs #13357

merged 4 commits into from Mar 2, 2016

Conversation

cmsbuild
Copy link
Contributor

Update pixel phase 1 condition in the customization file.
Delete the gain calibration fake conditions, the real gains should be used.
Move the pull request #13228 made from CMSSW_800_pre4 to pre6.

Automatically ported from CMSSW_8_0_X #13300 (original by @dkotlins).

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_8_1_X.

It involves the following packages:

CondTools/SiPixel
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry
SimGeneral/MixingModule

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @ggovi, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1, @wmtan, @makortel, @VinInn, @Martin-Grunewald, @dkotlins this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@civanch
Copy link
Contributor

civanch commented Feb 18, 2016

please test

@ianna
Copy link
Contributor

ianna commented Feb 19, 2016

please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11396/console

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

@ianna
Copy link
Contributor

ianna commented Feb 20, 2016

+1

@civanch
Copy link
Contributor

civanch commented Feb 20, 2016

+1

@ggovi
Copy link
Contributor

ggovi commented Feb 23, 2016

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@makortel
Copy link
Contributor

makortel commented Mar 1, 2016

Could thits PR be merged, please? It has been fully signed for a week (80X version #13300 almost two weeks), and it will be needed to continue the era migration of 2017 reco customization after #13477 gets merged. Thanks.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 2, 2016
@cmsbuild cmsbuild merged commit d42cb39 into cms-sw:CMSSW_8_1_X Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants