Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting Phase2Tracker Digitizer from 62X_SLHC release. Updated also T… #13368

Merged
merged 7 commits into from Mar 3, 2016
Merged

Porting Phase2Tracker Digitizer from 62X_SLHC release. Updated also T… #13368

merged 7 commits into from Mar 3, 2016

Conversation

cmsbuild
Copy link
Contributor

Adding first version of Phase2 Tracker Digitizer, porting it from 62X SLHC release. Also updated TrackerGeometry class in Geometry/TrackerGeometryBuilder moving the enum definition in the header file.

FYI @delaere @boudoul
Automatically ported from CMSSW_8_0_X #13185 (original by @suchandradutta).

Suchandra added 7 commits February 16, 2016 10:48
Porting Phase2Tracker Digitizer from 62X_SLHC release. Updated also T…
07ff2ec 
…rackerGeometry class in Geometry/TrackerGeometryBuilder moving the enum definition in the headerfile
cleaning the code removing un-used stuff
bdb7ab9
updating loops to range based for loops, added missing EDAnalyser, ma…
a7e3d47 
…de EDAnalysers thread safe
re-arranging interface files
94a977a
re-arranging interface files
2655808
Update following the comments in the PR : algorithm type changed from…
2f15e5e 
… string to enum, initialisation of detector list moved to begin lumi block, used vector instead of array, pixel killing done through config parameters, testing code moved to test folder
clean up in BuildFiles
dc47a4a
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Feb 18, 2016
@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_8_1_X.

It involves the following packages:

Geometry/TrackerGeometryBuilder
SimTracker/SiPhase2Digitizer

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @threus, @dgulhan, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@ianna
Copy link
Contributor

ianna commented Feb 19, 2016

please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11388/console

@cmsbuild
Copy link
Contributor Author

+1
Tested at: dc47a4a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13368/11388/summary.html

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13368/11388/summary.html

@ianna
Copy link
Contributor

ianna commented Feb 19, 2016

+1

@civanch
Copy link
Contributor

civanch commented Feb 19, 2016

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@delaere delaere mentioned this pull request Mar 1, 2016
Merged
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 3, 2016
@cmsbuild
Merge pull request #13368 from suchandradutta/80X_Phase2TrackerDigitizer
5f51356 
Porting Phase2Tracker Digitizer from 62X_SLHC release. Updated also T…
@cmsbuild cmsbuild merged commit 5f51356 into cms-sw:CMSSW_8_1_X Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed geometry-approved orp-approved simulation-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cmsbuild @ianna @civanch @davidlange6