Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cuts to SiStripMonitorTrack #13398

Merged
merged 3 commits into from Mar 17, 2016

Conversation

schneiml
Copy link
Contributor

This commit introduces 4 cuts to select only good quality tracks for the track-based histograms of SiStripMonitorTrack:

  • pT > 0.8
  • P > 2
  • numberOfValidTrackerHits > 6
  • normalizedChi2 < 10

These parameters were suggested by @dimattia and @jlagram, via @fioriNTU .

The cuts drop about 60% of all hits. They affect the track-based per-cm histograms in SiStripMonitorTrack. The off-track cluster based plots are unaffected.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_0_X.

It involves the following packages:

DQM/SiStripMonitorTrack

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@fioriNTU
Copy link
Contributor

@schneiml the cut on Chi2 is reverted in your message, the right cut is Chi2/ndof < 10, probably is this that drops the number of hits by 99%, it is not expected to have this poor efficiency by those cuts.
And the NumberOfHits it is not clear if is Tracker or Strip Hits, in my opinion should be StripHits, but let's ask again to Sandro.

@schneiml
Copy link
Contributor Author

@fioriNTU I suspected that. It is this way round in the e-mail, but given that it goes to ∞ for ndof -> 0...
Also, 99% is a similar amount to what the SiStrip residuals did, so I did not see it as obviously wrong...
Edit: no, actually the e-mail was right. But I checked at least twice...

@cmsbuild
Copy link
Contributor

Pull request #13398 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@schneiml
Copy link
Contributor Author

@fioriNTU Now the chi2 cut should be ok. We drop only around 60%.

@deguio
Copy link
Contributor

deguio commented Feb 22, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11447/console

@deguio
Copy link
Contributor

deguio commented Feb 22, 2016

if final please submit to 81x as well.
thanks,
F.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #13398 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

@schneiml
Copy link
Contributor Author

After further commuication with Alessandro and Jean-Laurent, the cuts are now only applied to the per-cm histograms. Also, the numberOfValidTrackerHits cut was confirmed.

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11629/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 17, 2016
@cmsbuild cmsbuild merged commit 67db1aa into cms-sw:CMSSW_8_0_X Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants