Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

era-aware T0 data processing setup #13417

Merged
merged 29 commits into from Feb 22, 2016

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Feb 21, 2016

Added era-based T0 scenarios

  • HeavyIonsEra_Run2_HI
  • cosmicsEra_Run2_2016, cosmicsEra_Run2_25ns, cosmicsEra_Run2_50ns
  • hcalnzsEra_Run2_2016, hcalnzsEra_Run2_25ns
  • ppEra_Run2_2016, ppEra_Run2_25ns, ppEra_Run2_50ns
    The naming convention is to have a suffix matching the era name.

Tested in 800, in particular, by inspection and comparison of the T0 config files generated with Configuration/DataProcessing/test/RunPromptReco.py.
The reco parts in matching old and new scenarios are functionally identical.

There are some relevant discrepancies in L1-related pieces; they are apparently due to missing modifiers in eras

  • csc trigger primitive emulator used in validation DQM needs Fix SLHC parameter for Run-2 emulation #13243
  • CSCTF emulator used in validation is missing gangedME1a setting to False (current era implementation has it functionally set to true in run2 scenarios)
  • 2016 l1extra and other pre-stage2 algorithms are set to read inputs from GCT, while it should probably be from stage1.

Old scenarios are still in place and will give the same results, but the plan is to remove them at some point in 81X cycle.

@hengne
It should be now also possible to move to eras in the relval matrix for data processing, however for some eras additional customizations are still needed (customisePostEra_Run2_25ns and customisePostEra_Run2_2016 are needed for the 25ns setups)

…: customizations with Run2 should still be cleaned up
…thods shared with cmsDriver/data processing to the end of the file with a message that they are to be removed in 81X
@slava77
Copy link
Contributor Author

slava77 commented Feb 21, 2016

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Feb 21, 2016
@cmsbuild
Copy link
Contributor

Pull request #13417 was updated. @civanch, @cvuosalo, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @slava77, @hengne, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor Author

slava77 commented Feb 21, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11429/console

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented Feb 22, 2016

@cmsbuild please test
the comparison script failed at the last step of copying files last time

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11431/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented Feb 22, 2016

+1

for #13417 0a11e49

  • jenkins tests pass and comparisons with baseline show no differences

davidlange6 added a commit that referenced this pull request Feb 22, 2016
@davidlange6 davidlange6 merged commit 5bc8f67 into cms-sw:CMSSW_8_0_X Feb 22, 2016
@franzoni
Copy link

franzoni commented Mar 1, 2016

hello @hengne ,
do you have nearly ready the modification of the promptReco-like workflow in the matrix
which needs to be updated following this PR (it's currently broken since the custom function has gone away) ?
AlCaDB needs to validate conditions. If not existing yet, we can compose it and circulate it back to you
cheers,
G.

@slava77

franzoni pushed a commit to franzoni/wmcontrol that referenced this pull request Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants