Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim trackrefactor 80X (fixes bug in electron HLT) #13438

Merged
merged 3 commits into from Mar 1, 2016
Merged

Fastsim trackrefactor 80X (fixes bug in electron HLT) #13438

merged 3 commits into from Mar 1, 2016

Conversation

lveldere
Copy link
Contributor

fix and put back #13320
after being reverted #13401

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_8_0_X.

It involves the following packages:

FastSimulation/Configuration
FastSimulation/EgammaElectronAlgos
FastSimulation/HighLevelTrigger
FastSimulation/Muons
FastSimulation/Tracking

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11477/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

+1

changes observed in comparisons in line with expectations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@lveldere lveldere changed the title Fastsim trackrefactor 80X Fastsim trackrefactor 80X (fixes bug in electron HLT) Feb 24, 2016
@lveldere
Copy link
Contributor Author

@davidlange6

This is a bug fix.
If the refactoring is not allowed in 80X,
i'll have to fix in a messy way.

@cmsbuild
Copy link
Contributor

Pull request #13438 was updated. @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11552/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

+1

changes observed in comparisons in line with expectation

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 1, 2016
Fastsim trackrefactor 80X (fixes bug in electron HLT)
@cmsbuild cmsbuild merged commit a5c91fe into cms-sw:CMSSW_8_0_X Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants