Fixed static anal warnings in SIM #13440
Conversation
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_8_1_X. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
@davidlange6, this PR is not very important, at the same time, there is no sense to keep it pending. There were 3 concerns to the one of 8_0: one was fixed; second cannot be changed - static member is needed for static method, otherwise the code is not compiled; the 3d - I put explanations about code which seems to be correct. |
|
|
||
| RHStopTracer::RHStopTracer(edm::ParameterSet const & p) { | ||
| edm::ParameterSet parameters = p.getParameter<edm::ParameterSet>("RHStopTracer"); | ||
| mStopRegular = parameters.getUntrackedParameter<bool>("stopRegularParticles", false); | ||
| mTraceEnergy = 1000 * parameters.getUntrackedParameter<double>("traceEnergy", 1.e20); // GeV->KeV | ||
| mTraceParticleNameRegex = parameters.getParameter<std::string>("traceParticle"); | ||
| mTraceEnergy = parameters.getUntrackedParameter<double>("traceEnergy", 1.e20); |
There was a problem hiding this comment.
@civanch - what are the units of this?
There was a problem hiding this comment.
@davidlange6 , G4 default unit is MeV, because this parameter of the class is used only to compare with G4 value, no conversion is needed. To clarify value a LogInfo printout is added, so user will see what is the value/unit of this energy.
|
+1 |
Fixed static anal warnings in SIM
This PR is produced instead include static analysis warnings fixes. No effect on production. Is done instead of #13349.