Fix AssociationMap in TrackRefitter #13445
Conversation
|
A new Pull Request was created by @aysent (Aysen Tatarinov) for CMSSW_8_0_X. It involves the following packages: TrackingTools/TrackRefitter @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@aysent please make a PR for 81X. @rovere @VinInn @aysent |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
AssociationMaps are a relict of the past that introduces huge performance penalties in particular in recent releases. By definition Track and Trajectory are in one by one correspondence and produced by the same producers. |
|
On 2/23/16 10:15 PM, Vincenzo Innocente wrote:
Hi Vincenzo, TrackingTools/TrackRefitter is in TRK purview, if I'm not mistaken Maybe a JIRA ticket will help this happen.
|
|
|
||
| // Get the RecTrack collection from the event | ||
| Handle<reco::TrackCollection> tracks; | ||
| event.getByToken(theTracksToken, tracks); | ||
|
|
||
| // Association map between Trajectory and Track | ||
| auto_ptr<TrajTrackAssociationCollection> trajTrackMap(new TrajTrackAssociationCollection(trajectoryCollectionRefProd, tracks)); |
There was a problem hiding this comment.
auto_ptr is deprecated. Please use unique_ptr or shared_ptr instead.
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #13445 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again. |
|
The tests are being triggered in jenkins. |
|
@cmsbuild please test |
|
+1 Small fix for track-trajectory map in track refitter. There should be no change in monitored quantities. The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-02-23-2300 show no significant differences, as expected. |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Fix AssociationMap in TrackRefitter
Starting with CMSSW 75X initialization of AssociationMap needs to be modified in some cases.
I followed comments in DataFormats/Common/interface/AssociationMap.h and discussion in:
https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3540.html
to make it work for TrackRefitter package.