Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim: New correction coefficients for HF 81X #13462

Merged
merged 1 commit into from Feb 26, 2016

Conversation

lveldere
Copy link
Contributor

No description provided.

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11502/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_8_1_X.

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/TrackerSetup

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

@Vlandr57

@lveldere
Copy link
Contributor Author

+1

Observed changes in comparisons are line with expectations.

Note: changes in tracking are related to different sequence of random numbers per event during simulation. Tested in private with larger sample and no significant changes are observed.

Thanks @Vlandr57 for the private validation samples.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Feb 26, 2016
FastSim: New correction coefficients for HF 81X
@davidlange6 davidlange6 merged commit c971f7a into cms-sw:CMSSW_8_1_X Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants